Inline code with hyperlink is now highlighted #289
Conversation
|
Hmm I looks like both travis and appveyor had some infrastructure problems on some builds |
|
lets encrypt has had some downtime so all the things are failing.
…On Fri, May 19, 2017 at 12:35 PM, Michał Budzyński ***@***.*** > wrote:
Hmm I looks like both travis and appveyor had some infrastructure problems
on some builds
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/azerupi/mdBook/pull/289#issuecomment-302751289>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABsimuXTo9Alxu7lMXz21-7_qIBxV4zks5r7cS4gaJpZM4Ngogu>
.
|
budziq
force-pushed
the
highlight
branch
2 times, most recently
from
6a09349
to
7e2f387
Compare
|
@budziq thanks for the PR! For the styling we use a CSS pre-processor called Stylus; so you shouldn't modify the CSS manually because it will get overwritten. Instead you should modify the stylus files and regenerate the CSS. Check out our brand new contribution guide and let us know if you encountered any difficulties we should document. 😄 |
|
Argh! Newbie mistake :( I'll look into stylus later today. Thanks for your tim! |
Inline code with hyperlink has now a different color then standard inline code and has a on hover underline.
|
I've updated the PR with changes into base.styl and the generated book.css (as seams to be the convention basing on git history). |
|
Thank you! :) |
|
Thanks! |
Inline code with hyperlink has now the same color and on hover underline as standard hyperlink.
This is how it looks in rust-cookbook
Please note that I have zero experience with css / webdev so I am really open to criticism.
solves: https://github.com/azerupi/mdBook/issues/261